JSON stringify string setting affects keys #11618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arBmind
force-pushed
the
json-stringify-patch
branch
3 times, most recently
from
0936505
to
6725941
Compare
daurnimator
approved these changes
May 10, 2022
* extracted outputJsonString to avoid code duplication
arBmind
force-pushed
the
json-stringify-patch
branch
from
6725941
to
10a671a
Compare
|
I rebased the commits on master and rearranged them to reflect best practices. Adding a failing test and fixing it afterwards. That way we can keep the original author for adding the test case. |
daurnimator
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #11459 and finally fixes #11455