A couple std.log conveniences #9224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows root.log implementations to capture log messages, process them, and forward them to the default implementation if desired.
marler8997
changed the title
LemonBoy
reviewed
Jun 24, 2021
| @@ -100,6 +100,23 @@ pub const Level = enum { | |||
| info, | |||
| /// Debug: messages only useful for debugging. | |||
| debug, | |||
|
|
|||
| /// Returns a string literal of the given level in full text form. | |||
| pub fn asText(comptime self: Level) switch (self) { | |||
There was a problem hiding this comment.
Why not implement a custom format?
There was a problem hiding this comment.
This is used to append the level "text" to other comptime strings, i.e.
level.asText() ++ ": " ++ fmt ++ "\n"There was a problem hiding this comment.
Ah, I see. The repetition in the return type and the function body is not that nice but I can't think of a way to DRY it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.logimplementationThis allows root.log implementations to capture log messages, process them, and forward them to the default implementation if desired.
This makes it easier to reproduce and customize the default log message style with the level prefix. This can be seen by the test cases in
compare_output.zig.