Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std/crypto: add scrypt kdf #9577

Merged
merged 1 commit into from Aug 24, 2021
Merged

std/crypto: add scrypt kdf #9577

merged 1 commit into from Aug 24, 2021

Conversation

x13a
Copy link
Contributor

@x13a x13a commented Aug 17, 2021

Hello everyone!

This is the second time to try to add scrypt kdf.

add scrypt kdf
add phc encoding parser
add password hashing functions to benchmark
change bcrypt to be consistent with scrypt

Previous pull: 8200
/cc @jedisct1

@jedisct1
Copy link
Contributor

Good job, @x13a ! And happy to see that CI is now green! 🎉

I'm going to review it as soon as possible.

Yescrypt is the successor to scrypt and is already used in Fedora and Debian, so we want to make sure that it can be added without breaking the API. The generic parameters should already take care of this. So only the fact that Yescrypt supports encryption might require a minor API change.

Thanks again for this!

@jedisct1 jedisct1 self-assigned this Aug 20, 2021
@jedisct1 jedisct1 added breaking Implementing this issue could cause existing code to no longer compile or have different behavior. standard library This issue involves writing Zig code for the standard library. labels Aug 20, 2021
jedisct1
jedisct1 reviewed Aug 22, 2021
View reviewed changes
lib/std/crypto/bcrypt.zig Outdated Show resolved Hide resolved
lib/std/crypto/phc_encoding.zig Show resolved Hide resolved
lib/std/crypto/phc_encoding.zig Outdated Show resolved Hide resolved
lib/std/crypto/scrypt.zig Outdated Show resolved Hide resolved
lib/std/crypto/scrypt.zig Outdated Show resolved Hide resolved
lib/std/crypto/bcrypt.zig Outdated Show resolved Hide resolved
add scrypt kdf
cafff18 
add phc encoding parser
add password hash functions to benchmark
change bcrypt to be consistent with scrypt
@jedisct1
Copy link
Contributor

Let's get this in! 🍻

@jedisct1 jedisct1 merged commit 8c41a8e into ziglang:master Aug 24, 2021
@x13a x13a deleted the scrypt branch August 24, 2021 13:30
@x13a x13a mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedisct1 jedisct1 jedisct1 left review comments

Assignees

@jedisct1 jedisct1

Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@x13a @jedisct1