Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reexport crypto/phc_encoding #9712

Merged
merged 1 commit into from Sep 9, 2021
Merged

reexport crypto/phc_encoding #9712

merged 1 commit into from Sep 9, 2021

Conversation

x13a
Copy link
Contributor

@x13a x13a commented Sep 9, 2021

Make phc_encoding public available in crypto.pwhash.phc_format. It is useful for serialization password hash functions that not available in std.

/cc @jedisct1

@jedisct1
Copy link
Contributor

jedisct1 commented Sep 9, 2021

Other serialization formats required for cryptographic operations may be good to have (S2V, constant-time hex/b64, PEM, etc).

So, instead of having all these in the top-level crypto namespace, how about a crypto.codecs or crypto.serialization namespace?

@jedisct1
Copy link
Contributor

jedisct1 commented Sep 9, 2021

Well... phc_format is really only useful in the context of password hashing functions, so having the relevant codecs exported here is intuitive.

So let's merge this :) And maybe reexport it in a codecs namespace once there is a justification for it.

Thanks!

@jedisct1 jedisct1 merged commit 3611487 into ziglang:master Sep 9, 2021
@jedisct1
Copy link
Contributor

jedisct1 commented Sep 9, 2021

(looking at the diff, I originally thought it was in the top-level namespace, but it is actually in crypto.pwhash, so... this is fine 😄)

@x13a x13a deleted the phc_encoding branch September 9, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants