Add Linux ioctl creation utilities #9748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very nice, i needed this in the past quite often already. |
Vexu
requested changes
Sep 16, 2021
Co-authored-by: Veikka Tuominen <git@vexu.eu>
zigazeljko
reviewed
Sep 17, 2021
Co-authored-by: zigazeljko <ziga.zeljko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shamelessly stolen from @mattnite 's now closed #6443 pull request, this adds some utilities for constructing modern IOCTLs, and also uses them in
linux.zigfor some constants that were previously broken on mips, powerpc, and sparc.From the ioctl manpages:
Therefore I have kept them as u32 values, and not as packed
Requeststructures. There previous PR had also messed up the flags a little:writeis 1 andreadis 2, not the inverse.