Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Ember Outgoing Message Type. #24

Merged
merged 3 commits into from
Jul 3, 2017

Conversation

AndreasBomholtz
Copy link
Contributor

@AndreasBomholtz AndreasBomholtz commented Jun 28, 2017

I found these new Ember Outgoing Message Type values in the Silabs Gateway Software. This is the missing types for issue #18.

@coveralls
Copy link

coveralls commented Jun 28, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5b92ee2 on Seluxit:add-new-ember-outgoing-message-type into b815be0 on rcloran:master.

@coveralls
Copy link

coveralls commented Jul 2, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 78634f5 on Seluxit:add-new-ember-outgoing-message-type into 381f356 on rcloran:master.

@coveralls
Copy link

coveralls commented Jul 3, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8418a1e on Seluxit:add-new-ember-outgoing-message-type into fa7cca4 on rcloran:master.

@rcloran
Copy link
Collaborator

rcloran commented Jul 3, 2017

This is slightly concerning to me... it's not clear to me what versions of what firmware use what constants to mean what, or if/when/why constants were re-numbered.

That said, it'll unblock stuff by stopping exceptions from being thrown so... yolo.

Thanks for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants