Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python3.5+ await syntax #5

Closed
jonatanolofsson opened this issue Feb 7, 2018 · 6 comments
Closed

Use python3.5+ await syntax #5

jonatanolofsson opened this issue Feb 7, 2018 · 6 comments

Comments

@jonatanolofsson
Copy link

jonatanolofsson commented Feb 7, 2018 •
edited
Loading

Home assistant is dropping python3.4 support, so it's time to update the zigpy syntax to use the await syntax. This also improves the support to e.g. spot unawaited futures.
@rcloran
Copy link
Collaborator

rcloran commented Feb 7, 2018

Happy to do this when HA drops 3.4 support.

@jonatanolofsson
Copy link
Author

It was dropped in October last year: https://home-assistant.io/blog/2017/10/06/deprecating-python-3.4-support/

@rcloran
Copy link
Collaborator

rcloran commented Feb 7, 2018

Nope. That was an announcement saying it will be dropped. https://github.com/home-assistant/home-assistant/blob/dev/tox.ini#L2

@Adminiuga
Copy link
Collaborator

I think it is reasonable to expect it will be dropped really soon, once PR #12921 -- upgrade to aiohttp3 goes through.

@balloob
Copy link

balloob commented Mar 5, 2018

The next release, 0.65, will bump the minimum version to Python 3.5.3

@AndreasBomholtz
Copy link
Contributor

It is fixed in PR #31.

@doudz doudz mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jonatanolofsson @rcloran @balloob @Adminiuga @AndreasBomholtz