Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No hover/go-to on zig-gamedev/zgui, culprit is usingnamespace #1218

Closed
foxnne opened this issue May 31, 2023 · 3 comments
Closed

No hover/go-to on zig-gamedev/zgui, culprit is usingnamespace #1218

foxnne opened this issue May 31, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@foxnne
Copy link

foxnne commented May 31, 2023

Zig Version

0.11.0-dev.3323+706bdf651

Zig Language Server Version

5d53f01

Steps to Reproduce

  • Clone zig-gamedev
  • Open sample using zgui
  • Autocomplete should work, but not hover or go-to definition.

Note: zgui uses usingnamespace to bring all of the elements into main.zig. Removing this and putting everything into gui.zig and correcting the build.zig for this fixes the issue.

Expected Behavior

Hover and go-to to work just like autocomplete

Actual Behavior

Autocomplete works great but not hover/go-to.

@foxnne
Copy link
Author

foxnne commented Jun 1, 2023

zig-gamedev just merged PR removing the usingnamespace usage, but it should be easy to repro, just using module and usingnamespace should cause the same issue.

@Techatrix
Copy link
Member

fixed by #1566.

@llogick
Copy link
Member

llogick commented Feb 4, 2024

fixed by #1566.

Had left this issue open because looking at the PR diff the issue is/was? with
pub usingnamespace @import("gui.zig");.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants