Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated LazyPath breaks with Zig master #104

Closed
SlaktarMicke92 opened this issue May 22, 2024 · 1 comment
Closed

Deprecated LazyPath breaks with Zig master #104

SlaktarMicke92 opened this issue May 22, 2024 · 1 comment

Comments

@SlaktarMicke92
Copy link

SlaktarMicke92 commented May 22, 2024

In Zig master, changes have been made to setting paths in build files, example:

.root_source_file = b.path("src/main.zig"),

Zap still uses the old way to do it, which results in the error given under Actual.

Actual

error: no field named 'path' in union 'Build.LazyPath'
        .root_source_file = .{ .path = "src/zap.zig" },

Expected

Build runs without errors

Source

The fix needed for this should not break in Zig 0.12:

https://ziglang.org/download/0.12.0/release-notes.html#introduce-bpath-deprecate-LazyPathrelative

Suggestion

Replace all .{ .path = "path/to/file.zig" }, to b.path("src/main.zig"), in build.zig for both Zap and facil.io

@SlaktarMicke92
Copy link
Author

Created a pull request: #105

@SlaktarMicke92 SlaktarMicke92 changed the title Build error on Zig master Deprecated LazyPath breaks Zig master May 22, 2024
@SlaktarMicke92 SlaktarMicke92 changed the title Deprecated LazyPath breaks Zig master Deprecated LazyPath breaks with Zig master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant