Failproof project setup #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aristarhys
changed the title
|
Since you mentioned in #74 that pyramid-arima isn't necessary anymore, let's see if we can get that one through. Once that's fixed we should no longer need this PR since we're unblocked for upgrades to 3.7+ |
|
@snazzyfox it looks like removing |
|
Yep, looks like it's scikit-learn blocking this from happening right now. Let's carry on the discussion in #76. I think it's still a good idea to run/test against multiple versions. |
|
No need for this after removal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess python 3.7 and later considered not supported (see https://github.com/zillow/luminaire/runs/1946332964)
On python 3.6
pyramid-arimawheel build will fail (but it will not affect the installation of dependency - just produce log noise) without a numpy installed, but it looks like it's not required to actually have it as dependecy - see #74P.S.
https://pip.pypa.io/en/latest/reference/pip_install/#controlling-setup-requires
There is a warning about how dangerous to use this keyword, but i guess it's ok for such simple case
It's also used in #77