You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running shab on any input produces the expected output plus one newline at the end of the output. This seems to be due to the way that appending the delimiter (SHAB_$id) to the output is implemented.
It's possible to bandaid this by passing the output to head -c-1, although I couldn't find a way to fix this at its root. I can PR the head fix, although I thought I'd open an issue in case someone can come up with a better solution
Edit: Looking over it, it seems like the first call to cat on line 28 can be replaced with head to do this without additional overhead, although looking over past issues on the repo, it seems like adding a dependency on head is something you're trying to avoid. https://github.com/zimbatm/shab/blob/b33927943dae0b80bf56a0424571ba3a5f45b8e1/shab#L28=
The text was updated successfully, but these errors were encountered:
It's honestly more of a correctness thing, just bugging me a little. I
could see why it wouldn't really need to be a priority.
Maybe opportunistically using head? Or just leave it be, I suppose
I'm leaning towards letting go of the correctness for that specific case. Just to keep things simple and dependency-free. This should be documented though.
Running shab on any input produces the expected output plus one newline at the end of the output. This seems to be due to the way that appending the delimiter (
SHAB_$id
) to the output is implemented.It's possible to bandaid this by passing the output to
head -c-1
, although I couldn't find a way to fix this at its root. I can PR thehead
fix, although I thought I'd open an issue in case someone can come up with a better solutionEdit: Looking over it, it seems like the first call to cat on line 28 can be replaced with head to do this without additional overhead, although looking over past issues on the repo, it seems like adding a dependency on head is something you're trying to avoid.
https://github.com/zimbatm/shab/blob/b33927943dae0b80bf56a0424571ba3a5f45b8e1/shab#L28=
The text was updated successfully, but these errors were encountered: