Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌸✨ Members: Invitation email should convey which Space and Person it came from #1481

Closed
2 tasks done
anaulin opened this issue May 18, 2023 · 6 comments
Closed
2 tasks done
Assignees
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🌸 Polish Improves the UX!

Comments

@anaulin
Copy link
Member

anaulin commented May 18, 2023

The current Space invitation email doesn't have much info about who / what is actually inviting you and to what, unless you already know what Convene is:

image
image

It would be good to:

@anaulin
Copy link
Member Author

anaulin commented May 18, 2023

@KellyAH assigning this to you in case you are looking for something to do, but don't feel obliged to do it!

@KellyAH
Copy link
Contributor

KellyAH commented May 19, 2023

Ooo exciting! I've never worked with the Rails Mailer templates before. Thanks so much @anaulin ! I'll give it a shot today and this weekend! 😄

@anaulin
Copy link
Member Author

anaulin commented May 19, 2023

@KellyAH thank you! Don't hesitate to send questions if you get stuck.

And in case you aren't aware of this feature: Rails mailer previews can be very helpful, see https://guides.rubyonrails.org/action_mailer_basics.html#previewing-emails

@zspencer zspencer changed the title Spaces: Invitation email should better convey which space / People it came from Members: Invitation email should convey which Space and Person it came from May 20, 2023
@zspencer
Copy link
Member

Great catch! I've linked the card to the "nearest-upstream-leaf" in the product garden wiki thing. We probably should split Invitations into it's own high level issue since Members is getting pretty overloaded; but I will do that "someday when I think about it."

@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🌸 Polish Improves the UX! labels May 20, 2023
@zspencer zspencer changed the title Members: Invitation email should convey which Space and Person it came from 🌸✨ Members: Invitation email should convey which Space and Person it came from May 20, 2023
@sentry-io
Copy link

sentry-io bot commented May 27, 2023

Sentry issue: CONVENE-1H

@zspencer
Copy link
Member

zspencer commented May 27, 2023

Sentry issue: CONVENE-1H

Whoops! Apparently sending an email with a from field missing an actual email address does not uhhh.... work...

We'll probably want to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🌸 Polish Improves the UX!
Projects
None yet
Development

No branches or pull requests

3 participants