Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should data_id have a default value #214

Open
PythonFZ opened this issue Oct 15, 2023 · 1 comment
Open

Should data_id have a default value #214

PythonFZ opened this issue Oct 15, 2023 · 1 comment

Comments

@PythonFZ
Copy link
Member

data_id: typing.Optional[int] = zntrack.zn.params(0)

data_id typically is either first or last configuration. The current way of having a default for the first configuration it is rather easy to make a mistake (certainly hasn't happend to me)

geopt = ips.calculators.ASEGeoOpt(
      model=cp2k,
      data=packmol.atoms,
      optimizer="BFGS",
      run_kwargs={"fmax": 0.5},
  )

  aimd = ips.calculators.CP2KYaml(
      data=geopt.atoms,
      cp2k_bin=None,
      cp2k_params="cp2k_md.yaml"
  )

This will simply ignore the GeoOpt. Should we remove the default value?

@PythonFZ
Copy link
Member Author

set to -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant