Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages #79

Open
PythonFZ opened this issue Jun 28, 2023 · 0 comments · Fixed by #81
Open

Better error messages #79

PythonFZ opened this issue Jun 28, 2023 · 0 comments · Fixed by #81

Comments

@PythonFZ
Copy link
Member

PythonFZ commented Jun 28, 2023 •
edited
Loading 

train_selection = val_selection.excluded_atoms

val_data += val_selection.atoms
train_data += train_selection #.atoms raises error

have something like: znflow.ConnectionError: connected attribute "list" has no attribute "atoms"

instead of:

TypeError: Can not add <class 'ipsuite.configuration_selection.random.RandomSelection'> to <class 'znflow.base.Connection'>.

and

AttributeError: 'Connection' object has no attribute 'atoms'
@PythonFZ PythonFZ linked a pull request Jun 29, 2023 that will close this issue
add custom exceptions #81
Merged
@PythonFZ PythonFZ reopened this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add custom exceptions zincware/ZnFlow
1 participant
@PythonFZ