Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile UI messy #160

Closed
Folyd opened this issue Feb 7, 2023 · 5 comments
Closed

Fix mobile UI messy #160

Folyd opened this issue Feb 7, 2023 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed level-easy

Comments

@Folyd
Copy link
Member

Folyd commented Feb 7, 2023

@Folyd Folyd added bug Something isn't working help wanted Extra attention is needed level-easy labels Feb 7, 2023
@Folyd Folyd changed the title Improve mobile UI messy Fix mobile UI messy Feb 7, 2023
@kiyov09
Copy link
Contributor

kiyov09 commented Feb 7, 2023

I think I can help with this one. Let me know.

@Folyd
Copy link
Member Author

Folyd commented Feb 8, 2023

Thanks, @kiyov09. zine uses Tailwind CSS to style the UI, here are the source lines related to this issue:

<div class="relative py-6 sm:px-8 transition ease-in-out sm:hover:scale-110 duration-500 border-gray-200">
{% if article.path -%}
<a class="group" href="{{ article.path }}">
{% else -%}
<a class="group" href="/{{ issue.slug }}/{{ article.slug }}">
{% endif -%}
<div class="zine-cover relative">
<span class="absolute top-4 right-4 text-white text-2xl font-bold"
style="color: #eee; text-shadow: 1px 1px 2px #000">
No. {{ loop.index }}
</span>
<img class="z-0 w-full max-h-52 md:max-h-72 object-cover" loading="lazy" src="{{ article.cover }}"
alt="{{ article.title }}" />
</div>
<div class="my-4 text-2xl text-black">
<div
class="zine-card-title pb-4 font-bold line-clamp-2 group-hover:underline decoration-8 underline-offset-1 decoration-primary">
{{ article.title }}
</div>
</div>
</a>
<div class="flex sm:px-8 items-center justify-between text-base text-gray-500 absolute bottom-4 left-0 right-0">
<span class="zine-card-date">{{ article.pub_date }}</span>
{{ macros::author_link(author = article.author) }}
</div>
</div>

@kiyov09
Copy link
Contributor

kiyov09 commented Feb 8, 2023

Awesome. I'll start working on a solution right away. Is there anything I need to know before opening a PR?

@Folyd
Copy link
Member Author

Folyd commented Feb 8, 2023

Great, nothing else needs to know, feel free to open PR. 👍

@kiyov09
Copy link
Contributor

kiyov09 commented Feb 8, 2023

@Folyd
Just opened a PR for this issue #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed level-easy
Projects
None yet
Development

No branches or pull requests

2 participants