Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObservableQuery lifecycle hangs in pending for non-networked fetch policies #771

Closed
micimize opened this issue Nov 12, 2020 · 1 comment
Closed

ObservableQuery lifecycle hangs in pending for non-networked fetch policies #771

micimize opened this issue Nov 12, 2020 · 1 comment
Labels
v4 Issue with a v4 library

Comments

@micimize
Copy link
Collaborator

We set the lifecycle to pending without consideration of whether we're waiting for anything:
https://github.com/zino-app/graphql-flutter/blob/2efce9f15e59208d86a2c4b1c9e0794cc28ea680/packages/graphql/lib/src/core/observable_query.dart#L192-L194

This was found by @blaugold because it breaks cacheFirst -> refetch() behavior: #346 (comment)
@micimize micimize added the v4 Issue with a v4 library label Nov 12, 2020
@micimize micimize mentioned this issue Nov 12, 2020
Closed
@blaugold blaugold mentioned this issue Nov 30, 2020
Merged
@micimize
Copy link
Collaborator Author

closed by #777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v4 Issue with a v4 library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@micimize