Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't loop when matches is empty #17

Merged
merged 1 commit into from Nov 20, 2019
Merged

Conversation

ItsJimi
Copy link
Contributor

@ItsJimi ItsJimi commented Nov 20, 2019

Hi,

I've got an error on MdiIcons.fromString when Iterable<Match> matches = exp.allMatches(str); in MdiIcons.toCamelCase match nothing because for (Match m in matches) has an empty Iterable.
Let me know if you have requests.

Thanks

@ziofat
Copy link
Owner

ziofat commented Nov 20, 2019

That's weird, which icon can trigger this?

@ziofat ziofat merged commit fb2e02c into ziofat:master Nov 20, 2019
@ItsJimi
Copy link
Contributor Author

ItsJimi commented Nov 20, 2019

That's weird, which icon can trigger this?

I have this error with an empty string in parameter of MdiIcons.fromString but i think it crash for every string who don't match with the regex.
Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants