Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property type discovery must be more robust #53

Closed
pietervogelaar opened this issue Dec 18, 2012 · 1 comment
Closed

Property type discovery must be more robust #53

pietervogelaar opened this issue Dec 18, 2012 · 1 comment

Comments

@pietervogelaar
Copy link
Contributor

My observation right now without looking at any Swagger code is that the @var annotation of a property is taken literally. So @var integer will display the "integer" in the model/entity information.

But the swagger spec has only these data types:

byte             
boolean          
int             
long             
float            
double           
string           
Date

So mapping must be added:

PHP => Swagger
--------------------
bool => boolean
integer => int
\DateTime => Date

Swagger-codegen is very picky about data types, so it's important that for example integer is exactly "int".

@zircote
Copy link
Owner

zircote commented Dec 19, 2012

I agree and will address asap this week.

Thank you.

@bfanger bfanger closed this as completed in 2c734a0 Apr 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants