Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement device authorization grant? #141

Closed
arianvp opened this issue Nov 11, 2021 · 16 comments
Closed

Implement device authorization grant? #141

arianvp opened this issue Nov 11, 2021 · 16 comments
Labels
backend enhancement New feature or request help wanted Extra attention is needed sdk

Comments

@arianvp
Copy link

arianvp commented Nov 11, 2021

Is your feature request related to a problem? Please describe.
I want to authenticate my smart device which has no web browser with my phone. The https://oauth.net/2/device-flow/ flow fixes this.

It's quite commonly used in IoT and smart TVs. It's also used by some cloud CLIs (like awscli) to implement single sign on

Describe the solution you'd like
Implement the https://oauth.net/2/device-flow/ flow

Describe alternatives you've considered
none

Additional context
https://oauth.net/2/device-flow/

@arianvp arianvp added the enhancement New feature or request label Nov 11, 2021
@livio-a
Copy link
Member

livio-a commented Nov 12, 2021

Hey @arianvp

We definitely have it on the list for our OP implementation ZITADEL (https://docs.zitadel.ch/docs/apis/openidoauth/grant-types) but forgot to list it here in the readme.

You would be more interested in the RP part, right?

@arianvp
Copy link
Author

arianvp commented Nov 14, 2021

Actually interested in both

@livio-a
Copy link
Member

livio-a commented Nov 15, 2021

It would certainly be a nice enhancement for ZITADEL as well, but to be honest, it's not high on the priority list right now.

Would you consider implementing one part or even both of them? 😃

@ovk
Copy link

ovk commented Dec 3, 2021

I would be very interested in having device auth as well, as this is a hard requirement for our use-case.

@fforootd fforootd added the help wanted Extra attention is needed label Dec 4, 2021
@fforootd fforootd pinned this issue Dec 4, 2021
@fforootd fforootd unpinned this issue Apr 22, 2022
@vanpelt
Copy link

vanpelt commented May 16, 2022

💯 plus one. Good to know I'm not the only one excited about this.

@braginini
Copy link

braginini commented Jul 1, 2022

Same here. We'd love to see this feature implemented.
The only blocker for us not to go with zitadel at https://github.com/netbirdio/netbird

P.S. Currently we are using auth0

@fforootd
Copy link
Member

fforootd commented Jul 2, 2022

The only blocker for us not to go with zitadel at https://github.com/netbirdio/netbird

I like to hear about this 🥰

@hifabienne @livio-a let's discuss this again. Maybe it's time to solve this now. 😜

@livio-a
Copy link
Member

livio-a commented Jul 4, 2022

I suggest that we take a look at it at one of the two meetings tomorrow.

@braginini
Copy link

braginini commented Jul 27, 2022

FYI: We've just merged generic OIDC support in NetBird. Will be testing integration with Zitadel soon.
netbirdio/dashboard#9 (comment)

I suggest that we take a look at it at one of the two meetings tomorrow.

@livio-a did you have any progress on the device flow?

@fforootd
Copy link
Member

@braginini love to hear this

Let me chat with @hifabienne and @livio-a on how to schedule this.
We are close to release ZITADEL v2 and afterwards some of our stuff might have time to look at this.

@braginini
Copy link

Hey guys, any progress here?

@hifabienne
Copy link
Member

Hi @braginini

Sorry we have not yet started with this. And currently we can't tell you a specific time when this will be finished, since we still have some other features that are higher in priority.
We still think that this is something we like to implement soon.

Also PRs are highly appreciated. 😃

@mffap
Copy link
Member

mffap commented Jan 16, 2023

@hifabienne this seems to be the blocker for the sovereign cloud stack. Their IAM workgroup is currently evaluating ZITADEL as IAM component. Would be great, if you could take this into consideration for planning. I will get more information on 2023-01-16, if SCS would be able to contribute.

@hifabienne
Copy link
Member

I have created a user story according to this to be able to take it into our sprint planning, please subscribe to the following issue to get the updates on the state: #264

@fforootd
Copy link
Member

Just to raise some expectations 😁 #285

@muhlemmer
Copy link
Collaborator

Closing as done in #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request help wanted Extra attention is needed sdk
Projects
None yet
Development

No branches or pull requests

9 participants