Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom dial options to grpc connection #325

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

HaimKortovich
Copy link
Contributor

@HaimKortovich HaimKortovich commented Apr 10, 2024

Adds the possibility to provide custom dial option for the grpc connection

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer muhlemmer requested a review from livio-a April 17, 2024 09:32
@livio-a livio-a changed the title Add custom dial options to connection feat: add custom dial options to grpc connection Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (891b673) to head (4557d8e).

Files Patch % Lines
pkg/client/zitadel/client.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #325   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         76      76           
  Lines      77377   77382    +5     
=====================================
- Misses     77377   77382    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a merged commit b706706 into zitadel:main Apr 22, 2024
9 checks passed
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@livio-a
Copy link
Member

livio-a commented Apr 22, 2024

@HaimKortovich thanks for adding that possibility.
If you like to get a gift from us, please write an email to hi@zitadel.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants