Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups from LDAP #6270

Open
2 tasks done
mw-0 opened this issue Jul 25, 2023 · 7 comments
Open
2 tasks done

Groups from LDAP #6270

mw-0 opened this issue Jul 25, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@mw-0
Copy link

mw-0 commented Jul 25, 2023

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions
  • I have joined the ZITADEL chat

Describe your problem

Like a lot of people we have users in legacy AD. We currently use Keycloak for OIDC which includes the ad groups of the user in the userinfo endpoint. This can then be used for rbac inside the apps.

Describe your ideal solution

On Keycloak you can return the user groups as part of either userinfo or access token with the groups mapper.

Version

No response

Environment

Self-hosted

Additional Context

No response

@mw-0 mw-0 added the enhancement New feature or request label Jul 25, 2023
@fforootd
Copy link
Member

Hm we could extend our LDAP provider or create an action to map this infos around.

@k8ieone
Copy link

k8ieone commented Jul 30, 2023

This feels like a must have. Even simple IDPs like Dex or Authelia are able to return group membership info from an LDAP server.

@fforootd
Copy link
Member

Sure that is true, we should be able to extend this.

The reason we did hold back is basically because claims like groups do not exist in the standard.

So the best course on our end would be to allow people to use an action to map across the values into a token.

@fforootd
Copy link
Member

CC @hifabienne I guess this is something worth to extend actions ldap support

@hifabienne
Copy link
Member

Yes, I think actions is the right place for this.
I will put the issue to the product backlog for now, and we monitor the need of our customers/community, and will prioritise accordingly.
Meanwhile, if you're interested in implementing it yourself, we also welcome pull requests.

@cedegi
Copy link

cedegi commented Sep 1, 2023

I think, this could be a great improvement.

For us at wavestack we had three requests within the last two weeks by users, asking for managing projects with groups or even had this as an requirement for their usecase. Their is definitely a need for this and it could make things way more comfortable.

For now, this is not a requirement for c5 criteria (https://www.bsi.bund.de/SharedDocs/Downloads/DE/BSI/CloudComputing/Anforderungskatalog/2020/C5_2020.pdf?__blob=publicationFile&v=2), but this could also change in the future.

Lets keep in touch for this, if you have any questions how a good implementation could look like.

@ghstahl
Copy link

ghstahl commented Oct 1, 2023

I want the same thing but coming in as someone switching from Auth0 to zitadel.
btw: Some go code to pull groups.
azuread user groups

This is the options when I configure an AzureAD OIDC sso in Auth0.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📨 Product Backlog
Development

No branches or pull requests

6 participants