-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SMTP Templates #6932
feat: SMTP Templates #6932
Conversation
Call me excited about this PR. Thanks for all the hard work @doncicuto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doncicuto I had another look, I think they are small chances that I missed but would be a good idea. Could you have a look if the comments are clear for you?
No, thank you and specially to the whole team reviewing this issue. I hope that things work fine and my code can be fixed and improved during this review |
Many thanks @stebenz and @peintnermax for reviewing this PR, I really hope this code works fine and looks good to you and that it will ease the configuration of different providers. |
Thank you @doncicuto for this huge effort and seeing it through to the end! It's not easy when there are many reviewers involved 😄 |
Thank you for this superb PR ❤️ |
Thank you,How is Office365 configured? |
Hi @Beatirce, unfortunately I couldn't add a template for Office/Microsoft365 as I have no account to test against it. I created a PR on friday to add an outlook.com template and a fix that should allow login auth for smtp communication with that provider, but I've no way to test against Office365. I'm on Discord so if you or anybody interested in this feature want to contact me and provide an account to test I'd love to try (I'm not sure if Oauth with SMTP will be needed). |
🎉 This PR is included in version 2.50.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thanks,but I can't provide a test account,because I'm not postmaster,sorry. |
With this feature you are able to choose an SMTP template and default settings are already made, so you only have to give my configuration specific settings.
In this PR there are default settings for Amazon SES, Mailgun, Mailjet, Postmark, Sendgrid and a Generic SMTP provider. If you have known settings for other providers let me known and I'll add them during this review.
This is a video showing this feature:
mail_templates.mp4
This PR has many frontend/backend changes, some of them are breaking changes:
I've done my best, but I guess that many things will be wrong in backend as I'm still trying to learn more about it. I thank you in advance for your review
Closes #5503
Definition of Ready