Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display application name instead of client ID in device authorization grant message #7499

Open
2 tasks done
mlsmaycon opened this issue Mar 4, 2024 · 9 comments
Open
2 tasks done

Comments

@mlsmaycon
Copy link

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions
  • I have joined the ZITADEL chat

Describe your problem

As of today the device authorization flow grant message displays the client ID (see attachment) and there is no way to customize that. know it is not a big issue since the client ID is "public" information, but maybe showing the application name would be a better option or allowing administrators to customize the page as well.

image

Describe your ideal solution

As an administrator I want my users to see a more friendly information, either the application ID or allow for omiting the client ID from this message.

Version

2.47.0

Environment

Self-hosted

Additional Context

No response

@mlsmaycon mlsmaycon changed the title Display application instead of client ID in device authorization grant message Display application name instead of client ID in device authorization grant message Mar 4, 2024
@hifabienne
Copy link
Member

Thank you for sharing your idea.
If there is a significant demand from customers/community, we will carefully consider implementing the feature.
Currently, the issue will be added to our product backlog to collect feedback.

Meanwhile, if you're interested in implementing it yourself, we also welcome pull requests.

Relates also to this issue: #6120

@mlsmaycon
Copy link
Author

@hifabienne can you direct us to the relevant code for this message, maybe I will be able to contribute?

@hifabienne
Copy link
Member

@muhlemmer or @livio-a Can you help here?

@muhlemmer
Copy link
Contributor

The pointers that @hifabienne provided are the correct positions to set the name to the rendered HTML. The problem however is that the AuthRequest we get from the storage does not have the name, and therefore it is not available.

You will need to modify the domain.Authrequest to carry the name, and any queries that populate the authrequest to also obtain and set the app name. It might be a complex change.

type AuthRequest struct {
ID string
AgentID string
CreationDate time.Time
ChangeDate time.Time
BrowserInfo *BrowserInfo
ApplicationID string
CallbackURI string
TransferState string
Prompt []Prompt
PossibleLOAs []LevelOfAssurance
UiLocales []string
LoginHint string
MaxAuthAge *time.Duration
InstanceID string
Request Request
levelOfAssurance LevelOfAssurance
UserID string
UserName string
LoginName string
DisplayName string
AvatarKey string
PresignedAvatar string
UserOrgID string
RequestedOrgID string
RequestedOrgName string
RequestedPrimaryDomain string
RequestedOrgDomain bool
ApplicationResourceOwner string
PrivateLabelingSetting PrivateLabelingSetting
SelectedIDPConfigID string
LinkingUsers []*ExternalUser
PossibleSteps []NextStep `json:"-"`
PasswordVerified bool
MFAsVerified []MFAType
Audience []string
AuthTime time.Time
Code string
LoginPolicy *LoginPolicy
AllowedExternalIDPs []*IDPProvider
LabelPolicy *LabelPolicy
PrivacyPolicy *PrivacyPolicy
LockoutPolicy *LockoutPolicy
DefaultTranslations []*CustomText
OrgTranslations []*CustomText
SAMLRequestID string
}

@vigneshsankariyer1234567890
Copy link
Contributor

Hey, wondering if I could try this out!

@hifabienne
Copy link
Member

@mlsmaycon Are you working on this? Or would you be glad if @vigneshsankariyer1234567890 would try to implement?

@mlsmaycon
Copy link
Author

@mlsmaycon Are you working on this? Or would you be glad if @vigneshsankariyer1234567890 would try to implement?

I won't be able to do it for a couple of weeks. It would be great if @vigneshsankariyer1234567890 tries.

@hifabienne
Copy link
Member

@vigneshsankariyer1234567890
I assigned you to the issue, thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📨 Product Backlog
Development

No branches or pull requests

4 participants