Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add action v2 execution to features #7597

Merged
merged 14 commits into from
Apr 9, 2024
Merged

fix: add action v2 execution to features #7597

merged 14 commits into from
Apr 9, 2024

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented Mar 19, 2024 •
edited

Add a feature flag to manage executions and targets in the action v2 API.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@stebenz stebenz requested a review from muhlemmer March 19, 2024 13:17
@stebenz stebenz self-assigned this Mar 19, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 2:39pm

muhlemmer
muhlemmer reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you covered everything. Just commented on one small error.

internal/command/instance_features_model.go Show resolved Hide resolved
@muhlemmer muhlemmer mentioned this pull request Mar 21, 2024
Closed
10 tasks
@stebenz @muhlemmer
fix: update internal/command/instance_features_model.go
17dcf4e 
Co-authored-by: Tim Möhlmann <tim+github@zitadel.com>
@stebenz stebenz requested a review from muhlemmer April 5, 2024 12:13
muhlemmer
muhlemmer reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems vercel is also failing. I cannot check logs, but my best guess would be something needs to renamed in the docs as well, following the rename of protos.

Consider doing a local build to troubleshoot:

https://github.com/zitadel/zitadel/tree/main/docs#readme

internal/command/instance_features_test.go Outdated Show resolved Hide resolved
internal/command/system_features_test.go Outdated Show resolved Hide resolved
internal/domain/feature_enumer.go Outdated Show resolved Hide resolved
proto/zitadel/feature/v2beta/instance.proto Outdated Show resolved Hide resolved
@stebenz stebenz requested a review from muhlemmer April 9, 2024 15:49
@muhlemmer muhlemmer enabled auto-merge (squash) April 9, 2024 17:20
@muhlemmer muhlemmer merged commit 6dcdef0 into main Apr 9, 2024
25 checks passed
@muhlemmer muhlemmer deleted the action-v2-feature branch April 9, 2024 17:21
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhlemmer muhlemmer muhlemmer approved these changes

Assignees

@stebenz stebenz

Labels
released
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stebenz @muhlemmer