Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): keep default idps active #7663

Merged
merged 12 commits into from
Apr 11, 2024
Merged

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Mar 28, 2024

When I create a custom login policy, I want to take over the whole default login policy.
Most properties are already taken over, but not the idp list.

This PR fixes this.
It also centralizes creating new login policies, so the properties to take over are defined in one place and better maintainable.

The PR depends on #7667 (see description)

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 8:12am

@peintnermax peintnermax enabled auto-merge (squash) April 11, 2024 08:02
@peintnermax peintnermax merged commit 2de66dc into main Apr 11, 2024
25 checks passed
@peintnermax peintnermax deleted the keep-active-instance-idps branch April 11, 2024 08:29
Copy link

🎉 This PR is included in version 2.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Available IDPs are removed when saving organization login policy
2 participants