Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check idp existence by org id #7667

Merged
merged 10 commits into from
Apr 9, 2024
Merged

fix: check idp existence by org id #7667

merged 10 commits into from
Apr 9, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Mar 28, 2024

When creating a new custom policy, the list of IDPs is checked for existence.
For org IDPs, the events are queried by resource owner, which is not necessarily the org ID.
An existing org IDP is not found, and the create custom policy request fails.

This PR explicitly queries by org ID.
It also reuses the central ExistsIDP function to guarantee the same existence checking logic as in other API implementations.

I found this bug when I implemented #7663
image

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 7:12pm

@eliobischof eliobischof self-assigned this Mar 28, 2024
@eliobischof eliobischof linked an issue Mar 28, 2024 that may be closed by this pull request
@eliobischof eliobischof changed the title fix: search idp by org fix: check idp existence by org id Mar 28, 2024
@muhlemmer muhlemmer merged commit e8601de into main Apr 9, 2024
25 checks passed
@muhlemmer muhlemmer deleted the fix-idp-exists branch April 9, 2024 19:32
Copy link

🎉 This PR is included in version 2.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Available IDPs are removed when saving organization login policy
3 participants