fix: weird issue with service key expirationDate format #7688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hifabienne
added
the
os-contribution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7688 +/- ##
===========================================
+ Coverage 50.10% 62.84% +12.73%
===========================================
Files 1244 1302 +58
Lines 117337 107370 -9967
===========================================
+ Hits 58788 67472 +8684
+ Misses 55594 36023 -19571
- Partials 2955 3875 +920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peintnermax
approved these changes
Apr 23, 2024
|
🎉 This PR is included in version 2.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7686 @jbvv1 detected and issue with how the expiration dates for service users keys are displayed. For 12/31/2024 date it showed 12/31/2025.
As discussed in #7686 the date was correctly sent to backend and backend did store the date correctly but when the frontend showed the date it was wrong. I've checked that it was an issue with the pattern I've used: localizedDate: 'EEEE dd. MMM YYYY, HH:mm' showed a wrong year so I've changed it to localizedDate: 'EEEE dd. MMM yyyy, HH:mm'
As this pattern was used in two other cases I've replaced them as well, as I understand that yyyy should be a safe choice for DatePipe (https://angular.io/api/common/DatePipe)
Here's a sample where 2025 is no longer shown (first row):
Should close #7686
Definition of Ready