feat: provide option to limit (T)OTP checks #7693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # internal/command/user_human_otp.go
muhlemmer
reviewed
Apr 9, 2024
muhlemmer
approved these changes
Apr 10, 2024
peintnermax
approved these changes
Apr 10, 2024
livio-a
added a commit
that referenced
this pull request
Apr 10, 2024
* feat: provide option to limit (T)OTP checks * fix requests in console * update errors pkg * cleanup * cleanup * improve naming of existing config
|
🎉 This PR is included in version 2.50.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing option to automatically lock a user after a certain amount of wrong password checks, this PR adds an option to the lockout policy to do the same for (T)OTP checks.
Note that each OTP method is treated individually. Meaning that if the lockout is set to 3, after 2 failed TOTP checks, the user would still be able to potentially try the TOTP email verification more than once.
Note
The existing
MaxAttemptsin the configuration for DefaultInstance and FirstInstance has been changed toMaxPasswordAttempts.Definition of Ready