Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(console): feature settings #7713

Merged
merged 14 commits into from
Apr 10, 2024
Merged

feat(console): feature settings #7713

merged 14 commits into from
Apr 10, 2024

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Apr 5, 2024 •
edited

This PR implements an additional feature settings page in the default settings

Closes #7604
Screenshot 2024-04-10 at 18 00 19

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 4:15pm

@peintnermax peintnermax marked this pull request as ready for review April 9, 2024 13:56
eliobischof
eliobischof requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons show enabled for inherited features.

@peintnermax peintnermax enabled auto-merge (squash) April 10, 2024 16:20
@peintnermax peintnermax merged commit 2061d1a into main Apr 10, 2024
25 checks passed
@peintnermax peintnermax deleted the cnsl-features branch April 10, 2024 16:30
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add feature settings to the console
2 participants
@peintnermax @eliobischof