Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware): init translation messages #7778

Merged
merged 6 commits into from
Apr 16, 2024
Merged

fix(middleware): init translation messages #7778

merged 6 commits into from
Apr 16, 2024

Conversation

adlerhurst
Copy link
Member

Instead of loading the translation files for each request the files are cached on startup.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 11:55am

@adlerhurst adlerhurst requested a review from livio-a April 16, 2024 10:06
@adlerhurst adlerhurst marked this pull request as ready for review April 16, 2024 10:06
livio-a
livio-a reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@livio-a livio-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and weirdly integration tests fail, since they have an issue finding the namespaces 🤷

internal/i18n/bundle.go Outdated Show resolved Hide resolved
@adlerhurst adlerhurst enabled auto-merge (squash) April 16, 2024 11:41
@adlerhurst adlerhurst merged commit 9bcfa12 into main Apr 16, 2024
25 checks passed
@adlerhurst adlerhurst deleted the init-translation-messages branch April 16, 2024 12:08
livio-a pushed a commit that referenced this pull request Apr 16, 2024
@adlerhurst @livio-a
fix(middleware): init translation messages (#7778)
e4843d7 
* fix(middleware): init translation messages

* revert change

* refactor: split loop in separate function

* add imports to ensure init of fs

(cherry picked from commit 9bcfa12)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livio-a livio-a livio-a approved these changes

Assignees
No one assigned
Labels
released
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adlerhurst @livio-a