Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: cache auth request in memory #7824

Merged
merged 8 commits into from
Apr 23, 2024
Merged

perf: cache auth request in memory #7824

merged 8 commits into from
Apr 23, 2024

Conversation

adlerhurst
Copy link
Member

Introduces an inmemory cache for auth requests, the cache also includes the policies.

Part of #7639

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 11:23am

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 46.90265% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 62.82%. Comparing base (cc56eea) to head (24e3022).
Report is 395 commits behind head on main.

❗ Current head 24e3022 differs from pull request most recent head 4e5c017. Consider uploading reports for the commit 4e5c017 to get more accurate results

Files Patch % Lines
internal/auth_request/repository/cache/cache.go 42.62% 32 Missing and 3 partials ⚠️
...epository/eventsourcing/eventstore/auth_request.go 43.18% 18 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7824       +/-   ##
===========================================
+ Coverage   50.10%   62.82%   +12.72%     
===========================================
  Files        1244     1312       +68     
  Lines      117337   108796     -8541     
===========================================
+ Hits        58788    68354     +9566     
+ Misses      55594    36503    -19091     
- Partials     2955     3939      +984     
Flag Coverage Δ
core-integration-tests-postgres 62.82% <46.90%> (+38.39%) ⬆️
core-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adlerhurst adlerhurst merged commit 25030c6 into main Apr 23, 2024
25 checks passed
@adlerhurst adlerhurst deleted the auth-request-cache branch April 23, 2024 11:23
livio-a pushed a commit that referenced this pull request Apr 23, 2024
* perf: cache auth request in memory

(cherry picked from commit 25030c6)
Copy link

🎉 This PR is included in version 2.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants