Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): app details #7827

Merged
merged 9 commits into from
Apr 29, 2024
Merged

fix(console): app details #7827

merged 9 commits into from
Apr 29, 2024

Conversation

eliobischof
Copy link
Member

The app details for OIDC apps show the SAML config and URLs. In the OIDC apps URLs section, the OIDC URLs are not even listed, only the useless SAML URLs.

This PR fixes this bug introduced with #7572.

The following screenshots show the new details pages.

API

image
image

OIDC

image
image

SAML

image
image

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 10:11am

@eliobischof eliobischof changed the title cleanup app urls fix: app details Apr 22, 2024
@eliobischof eliobischof changed the title fix: app details fix(console): app details Apr 22, 2024
@eliobischof eliobischof self-assigned this Apr 22, 2024
@eliobischof eliobischof added the reviewer wanted When you read this, please request your own review label Apr 22, 2024
@eliobischof eliobischof linked an issue Apr 22, 2024 that may be closed by this pull request
2 tasks
@eliobischof eliobischof marked this pull request as ready for review April 22, 2024 16:19
@eliobischof eliobischof removed the reviewer wanted When you read this, please request your own review label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.79%. Comparing base (cc56eea) to head (341f91f).
Report is 405 commits behind head on main.

❗ Current head 341f91f differs from pull request most recent head 1cb718e. Consider uploading reports for the commit 1cb718e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7827       +/-   ##
===========================================
+ Coverage   50.10%   62.79%   +12.68%     
===========================================
  Files        1244     1312       +68     
  Lines      117337   108839     -8498     
===========================================
+ Hits        58788    68342     +9554     
+ Misses      55594    36567    -19027     
- Partials     2955     3930      +975     
Flag Coverage Δ
core-integration-tests-postgres 62.79% <ø> (+38.36%) ⬆️
core-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a
Copy link
Member

livio-a commented Apr 23, 2024

works, but IMO we should add at least the introspection_endpoint and jwks_uri and maybe even revocation_endpoint for APIs.

@eliobischof
Copy link
Member Author

works, but IMO we should add at least the introspection_endpoint and jwks_uri and maybe even revocation_endpoint for APIs.

I mapped the URLs explicitly, fixed their order, added the mentioned URLs to the API and prettified the keys.
image

@livio-a
Copy link
Member

livio-a commented Apr 26, 2024

sorry apparently overlooked that before, but just noted that the issuer is missing on the OIDC configs
and wouldn't it make sense to have the entityID / metadata endpoint on the SAML config, resp. could we even use that for the link instead of well-known? maybe also any input on that from @stebenz?

@peintnermax peintnermax merged commit 8c1a8f7 into main Apr 29, 2024
25 checks passed
@peintnermax peintnermax deleted the fix-app-links branch April 29, 2024 10:17
Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 2.51.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keys endpoint on application urls
3 participants