-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(console): app details #7827
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7827 +/- ##
===========================================
+ Coverage 50.10% 62.79% +12.68%
===========================================
Files 1244 1312 +68
Lines 117337 108839 -8498
===========================================
+ Hits 58788 68342 +9554
+ Misses 55594 36567 -19027
- Partials 2955 3930 +975
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
works, but IMO we should add at least the |
sorry apparently overlooked that before, but just noted that the issuer is missing on the OIDC configs |
🎉 This PR is included in version 2.51.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The app details for OIDC apps show the SAML config and URLs. In the OIDC apps URLs section, the OIDC URLs are not even listed, only the useless SAML URLs.
This PR fixes this bug introduced with #7572.
The following screenshots show the new details pages.
API
OIDC
SAML
Definition of Ready