Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login): correctly reload policies on auth request #7839

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix(login): correctly reload policies on auth request #7839

merged 1 commit into from
Apr 24, 2024

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Apr 24, 2024 •
edited

A bug was introduced with #7824, which would not correctly reload policies and idps in case the organization was change during the authentication.

fixes #7837

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 8:29am

@adlerhurst adlerhurst self-requested a review April 24, 2024 08:18
@livio-a livio-a marked this pull request as ready for review April 24, 2024 08:21
@livio-a livio-a enabled auto-merge (squash) April 24, 2024 08:21
@livio-a livio-a merged commit ac985e2 into main Apr 24, 2024
26 checks passed
@livio-a livio-a deleted the fix-auth-req-cache branch April 24, 2024 08:44
adlerhurst pushed a commit that referenced this pull request Apr 24, 2024
@livio-a @adlerhurst
fix(login): correctly reload policies on auth request (#7839)
220c09d
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerhurst adlerhurst adlerhurst approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: External login provider not allowed
2 participants
@livio-a @adlerhurst