fix: improve secret generation for apple idp #7843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7843 +/- ##
===========================================
+ Coverage 50.10% 62.98% +12.88%
===========================================
Files 1244 1333 +89
Lines 117337 110058 -7279
===========================================
+ Hits 58788 69325 +10537
+ Misses 55594 36783 -18811
- Partials 2955 3950 +995
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adlerhurst
approved these changes
Apr 26, 2024
livio-a
added a commit
that referenced
this pull request
Apr 29, 2024
* fix: improve secret generation for apple idp * remove accidental commit * change exp time * change exp time * change exp time * change exp time (cherry picked from commit 6ab06aa)
|
🎉 This PR is included in version 2.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer reported that the login with Apple not always works, but often an invalid_client is returned.
We saw duplicate invocation of the callback in the logs, but are missing detailed information.
This PR adds additional logs. Since the authentication is relying on JWT, we also change the
iatby 2 seconds into the past to mitigate potential clock skew problems.Additionally a previous unintended change in the config parsing is removed.
Definition of Ready