Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translate missing event types #7853

Merged
merged 6 commits into from
Apr 29, 2024
Merged

fix: translate missing event types #7853

merged 6 commits into from
Apr 29, 2024

Conversation

hifabienne
Copy link
Member

@hifabienne hifabienne commented Apr 26, 2024

Add missing translations on event types and correct wrong example in api

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 1:28pm

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.99%. Comparing base (cc56eea) to head (35b58c8).
Report is 408 commits behind head on main.

❗ Current head 35b58c8 differs from pull request most recent head e521dfd. Consider uploading reports for the commit e521dfd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7853       +/-   ##
===========================================
+ Coverage   50.10%   62.99%   +12.89%     
===========================================
  Files        1244     1333       +89     
  Lines      117337   110058     -7279     
===========================================
+ Hits        58788    69335    +10547     
+ Misses      55594    36776    -18818     
- Partials     2955     3947      +992     
Flag Coverage Δ
core-integration-tests-postgres 62.99% <ø> (+38.56%) ⬆️
core-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/static/i18n/cs.yaml Outdated Show resolved Hide resolved
Co-authored-by: Livio Spring <livio.a@gmail.com>
@hifabienne hifabienne requested a review from livio-a April 29, 2024 11:51
@hifabienne hifabienne merged commit 2a421a7 into main Apr 29, 2024
25 checks passed
@hifabienne hifabienne deleted the event_types_translation branch April 29, 2024 13:33
Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 2.51.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing localizations for Project Application OIDC key event names
2 participants