-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(setup): decode complex config strings #7854
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7854 +/- ##
==========================================
+ Coverage 62.98% 63.00% +0.02%
==========================================
Files 1333 1333
Lines 110076 110078 +2
==========================================
+ Hits 69327 69360 +33
+ Misses 36800 36772 -28
+ Partials 3949 3946 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 2.51.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The env variable ZITADEL_INTERNALAUTHZ_ROLEPERMISSIONMAPPINGS works for the start command but not for the setup command.
In the setup decoders, the complex string type is tried to be decoded AFTER the string is already split by comma into a slice of meaningless strings by the string list decoder.
With this PR...
The bug was reported on Discord.
Definition of Ready