Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct email headers (mime version and content-type) #7886

Merged
merged 2 commits into from
May 2, 2024

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented May 1, 2024

As noticed by a customer (relates to #7880), the Mime-Version and Content-Type were not properly formatted, which depending on the smtp relay led to bad spam scoring.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@stebenz stebenz self-assigned this May 1, 2024
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 5:39am

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.00%. Comparing base (6c0e7c4) to head (f74c4e9).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/notification/messages/email.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7886      +/-   ##
==========================================
- Coverage   63.00%   63.00%   -0.01%     
==========================================
  Files        1333     1333              
  Lines      110078   110078              
==========================================
- Hits        69354    69350       -4     
- Misses      36775    36779       +4     
  Partials     3949     3949              
Flag Coverage Δ
core-integration-tests-postgres 63.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a changed the title fix: correct email mime version case for case-sensitive handlers fix: correct email headers (mime version and content-type) May 2, 2024
@livio-a livio-a merged commit 8cc12e8 into main May 2, 2024
25 of 27 checks passed
@livio-a livio-a deleted the mime-version-case branch May 2, 2024 08:36
Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 2.51.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants