Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user registration through IdP #7893

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: user registration through IdP #7893

merged 2 commits into from
May 2, 2024

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented May 2, 2024

fixes a nil pointer panic (introduced with #7815), which occurred after a user was registered through an IdP.
While checking the logs, further panics were discovered and fixed in this PR.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 1:05pm

@livio-a livio-a marked this pull request as ready for review May 2, 2024 12:27
stebenz
stebenz previously approved these changes May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@83c5066). Click here to learn what that means.

Files Patch % Lines
internal/command/user_human.go 0.00% 5 Missing ⚠️
internal/api/ui/login/init_user_handler.go 0.00% 3 Missing ⚠️
internal/api/ui/login/mfa_verify_otp_handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7893   +/-   ##
=======================================
  Coverage        ?   63.01%           
=======================================
  Files           ?     1333           
  Lines           ?   110084           
  Branches        ?        0           
=======================================
  Hits            ?    69370           
  Misses          ?    36772           
  Partials        ?     3942           
Flag Coverage Δ
core-integration-tests-postgres 63.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a changed the title fix: user registration through idp fix: user registration through IdP May 2, 2024
@stebenz stebenz enabled auto-merge (squash) May 2, 2024 13:00
@stebenz stebenz merged commit 482a46b into main May 2, 2024
27 checks passed
@stebenz stebenz deleted the idp-panic branch May 2, 2024 13:21
Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 2.51.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants