Add ESLint #16
Merged
Add ESLint #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrishelgert Can you please review my changes? |
|
Sure, will look later @ it :) |
chrishelgert
suggested changes
Nov 15, 2016
There was a problem hiding this comment.
@danielbayerlein please check the review-comments ;) the rest looks fine
| @@ -7,7 +7,8 @@ describe('helpers', () => { | |||
| const spans = defaultConfig.spans; | |||
|
|
|||
| beforeEach(() => { | |||
| spans.forEach((span) => { | |||
| spans.forEach((currentSpan) => { | |||
There was a problem hiding this comment.
should have a different meaning - maybe make spans a let and use map to iterate over the spans and clear the responses:
let spans = defaultConfig.spans;
// ....
spans = spans.map((currentSpan) => {
const span = currentSpan;
span.responses = [];
return span;
});
// ...|
|
||
| // Add the "/return-status/{statusCode}" route | ||
| server.route({ | ||
| method: 'GET', | ||
| path: '/return-status/{statusCode}', | ||
| handler: function (request, reply) { | ||
| handler: function handler(request, reply) { |
There was a problem hiding this comment.
why no arrow-function and parse the statusCode initial?
handler: (request, reply) => {
const statusCode = parseInt(request.params.statusCode, 10);
return reply(statusCode).code(statusCode);
};| @@ -16,7 +14,8 @@ module.exports = (server, spans) => { | |||
| }); | |||
| }); | |||
|
|
|||
| spans.forEach((span) => { | |||
| spans.forEach((currentSpan) => { | |||
There was a problem hiding this comment.
spans is not reused. I think it's 👌
| @@ -5,50 +5,50 @@ const onHeadersListener = require('./helpers/on-headers-listener'); | |||
| const socketIoInit = require('./helpers/socket-io-init'); | |||
|
|
|||
| // hapi.js plugin register function | |||
| var middlewareWrapper = function (server, options, next) { | |||
| options = validate(options); | |||
| const middlewareWrapper = function middlewareWrapper(server, options, next) { | |||
|
@chrishelgert Thanks for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13