Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the gregorian package #80

Closed
ThomasThelen opened this issue Apr 11, 2022 · 2 comments
Closed

Replace the gregorian package #80

ThomasThelen opened this issue Apr 11, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ThomasThelen
Copy link
Collaborator

gregorian isn't on cran an we can't submit until it is-so let's replace it with lubridate

@ThomasThelen ThomasThelen self-assigned this Apr 11, 2022
@ThomasThelen ThomasThelen added the enhancement New feature or request label Apr 11, 2022
@zizroc
Copy link
Owner

zizroc commented Apr 11, 2022

Let's just drop this. Having dates doesn't presently add value to the package and it's actually opposing generalization: it's a holdover from when we were thinking about exogenous drivers of change from the climate, and it imposes a calendar system that would have been totally alien to Maya. We can just do time steps with arbitrary labels -- days by default (because of how rates are presently entered), but could be anything. Also in case someone wants to subclass in a way we're not predicting. Why limit? In the future, we can write a few functions to reconstruct Mayan/Gregorian/Julian calendar dates from the output days.

@ThomasThelen
Copy link
Collaborator Author

Done in 014869b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants