Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts supporting wider set of diacritics and accented characters #71

Open
whizz opened this issue Sep 1, 2022 · 5 comments
Open

Fonts supporting wider set of diacritics and accented characters #71

whizz opened this issue Sep 1, 2022 · 5 comments
Milestone

Comments

@whizz
Copy link

whizz commented Sep 1, 2022

The change introduced #48, while generally a step in the right direction, unfortunately broke my non-latin site, because the local fonts are only in latin set, which does not contain some Czechs letters (such as ě,š,...) and I am sure many others from other languages.

I could submit a PR which would include the full font character set, but that would of course increase the size of the font files.

Alternatively, there could be some configuration setting to select the desired sets, but that will be quite complicated to do and use.

Or I can do that locally on my site, replacing the fonts.css with my own version and add the proper font files.

What do you think, @janraasch ? BTW: Thank you so much for creating the theme and sharing it with us.

@janraasch
Copy link
Collaborator

Hi @whizz, thank you for getting in touch 👍.

Alternatively, there could be some configuration setting to select the desired sets, but that will be quite complicated to do and use.

I agree 💯- %. I'd say that's out of scope.

Could you open a pr

which would include the full font character set

please 🙏? Then, we can check how much of an increase in filesize this is. Maybe it's not that much 😇 ☺️?!

If it seems too big, we'll go with

Or I can do that locally on my site, replacing the fonts.css with my own version and add the proper font files.

Sounds like a plan?


BTW: Thank you so much for creating the theme and sharing it with us.

Thank you for the kind words. You have to thank Yonatan Wolowelsky for the original theme though. I just ported it from Ghost to Hugo 🤓😄.

@whizz
Copy link
Author

whizz commented Sep 5, 2022

Apparently, Open Sans Condensed is no longer available at Google Fonts 🤦‍♂️ I'll have to figure out what to do about it.

@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on - potentilly falsely applied by stalebot, use invalid label instead label Nov 9, 2022
@stale stale bot closed this as completed Nov 27, 2022
@TheLastGimbus
Copy link
Contributor

Lighthouse gives me this warning:

Ensure text remains visible during webfont load

Leverage the font-display CSS feature to ensure text is user-visible while webfonts are loading. Learn more.

Could you add font-display: swap; to all fonts? Or can i make a PR?

But the way, i 2nd this issue. I would like to have easy option to disable custom fonts

@zjedi zjedi removed the wontfix This will not be worked on - potentilly falsely applied by stalebot, use invalid label instead label Mar 11, 2023
@zjedi zjedi reopened this Mar 11, 2023
@zjedi zjedi changed the title Only latin local fonts Fonts supporting wider set of diacritics and accented characters Mar 11, 2023
@zjedi
Copy link
Owner

zjedi commented Mar 11, 2023

@whizz This is also issue for me, you you have any specific fonts in mind?

@zjedi zjedi added the question label Mar 12, 2023
@zjedi zjedi added this to the v2.0 milestone Apr 2, 2023
@zjedi zjedi modified the milestones: v2.0, v2.1 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants