Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP server is matching links inside fenced code blocks #194

Closed
mickael-menu opened this issue Apr 23, 2022 · 4 comments · Fixed by #399
Closed

LSP server is matching links inside fenced code blocks #194

mickael-menu opened this issue Apr 23, 2022 · 4 comments · Fixed by #399
Labels
bug Something isn't working

Comments

@mickael-menu
Copy link
Member

Originally posted by @daephx in https://github.com/mickael-menu/zk/issues/22#issuecomment-1107476645

I don't know if this was mentioned but I didn't see any other relevant issues. It appears the LSP attempts to check wikilink syntax within code blocks. Which is probably a rare issue but still doesn't strike me as appropriate behavior.
I only noticed this due to the multi-line string syntax Lua uses.

image

@mickael-menu mickael-menu added the bug Something isn't working label Apr 23, 2022
@pidgeon777
Copy link

@mickael-menu are you using Vim/Neovim?

Could you please post your LSP config to enable zk inside it?

Best regards

@mickael-menu
Copy link
Member Author

My config is very basic. I'm using zk-nvim with:

require("zk").setup({
  picker = "telescope",

  lsp = {
    -- `config` is passed to `vim.lsp.start_client(config)`
    config = {
      cmd = {'zk', 'lsp', '--log', '/tmp/zk-lsp.log'},
      name = "zk",
    },

    -- automatically attach buffers in a zk notebook that match the given filetypes
    auto_attach = {
      enabled = true,
      filetypes = { "markdown" },
    },
  },
})

And ftplugin to add the mappings, as described here: https://github.com/mickael-menu/zk-nvim#example-mappings The sample ~/.config/nvim/ftplugin/markdown.lua is mine.

@tjex
Copy link
Member

tjex commented Jan 11, 2024

Confirmed this is still happening, could potentially be looked at together with #250

@tjex
Copy link
Member

tjex commented Apr 1, 2024

Work for this is in progress by @Rahlir as mentioned here in the same issue but over on zk-nvim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants