Merge pull request #12688 from Szpoti/fixKnotsOnWIndows

Fix wrong `DataDir` error on Windows for Knots
WalletWasabi · Mar 19, 2024 · 8951440 · 8951440
2 parents 8dadf3e + 68aed7a
commit 8951440
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/WalletWasabi/BitcoinCore/Processes/BitcoindRpcProcessBridge.cs b/WalletWasabi/BitcoinCore/Processes/BitcoindRpcProcessBridge.cs
@@ -1,5 +1,6 @@
 using NBitcoin;
 using System.IO;
+using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 using WalletWasabi.Bases;
@@ -49,7 +50,12 @@ public async Task StartAsync(CancellationToken cancel)
 		string processPath = MicroserviceHelpers.GetBinaryPath("bitcoind");
 		string networkArgument = NetworkTranslator.GetCommandLineArguments(Network);
 
-		string args = $"{networkArgument} -datadir=\"{DataDir}\" -printtoconsole={ptcv}";
+		// On Windows, if DataDir ends with '\', the Process can't be started.
+		string dataDir = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && DataDir.EndsWith('\\')
+					 ? DataDir[..^1]
+					 : DataDir;
+
+		string args = $"{networkArgument} -datadir=\"{dataDir}\" -printtoconsole={ptcv}";
 
 		// Start bitcoind process.
 		Process = new ProcessAsync(ProcessStartInfoFactory.Make(processPath, args));