Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Newtonsoft json serializer to System.Text.Json source generator version #10292

Closed
wieslawsoltes opened this issue Mar 14, 2023 · 6 comments

Comments

@wieslawsoltes
Copy link
Collaborator

General Description

During memory profiling in search of memory leaks (#10051) I have found that Newtonsoft json allocates a lot of memory (1.9GB) during app startup (my wallets in total are 22 MB of json).

Maybe migrating to System.Text.Json source generator version would improve that. Also System.Text.Json source generator version is AOT friendly for publishing NativeAOT apps.

How To Reproduce?

  1. Run app under memory profiler

Screenshots

image

Operating System

Windows 10

Logs

Wasabi Version

master

@wieslawsoltes
Copy link
Collaborator Author

Looking deeper it might not be all json serialize that is allocating
image

@yahiheb
Copy link
Collaborator

yahiheb commented Mar 14, 2023

This is duplicate of #4223?

@molnard
Copy link
Collaborator

molnard commented Mar 22, 2023

This might be solved by #10272
So we will wait for this until there will be a decision on that.

@molnard
Copy link
Collaborator

molnard commented May 1, 2023

@wieslawsoltes #10272 merged. Can you check if this is still an issue?

@molnard
Copy link
Collaborator

molnard commented Aug 29, 2023

I moved this to "Not now". I do not see the perspective.

@wieslawsoltes wieslawsoltes removed their assignment Jan 22, 2024
@molnard
Copy link
Collaborator

molnard commented Jan 25, 2024

Useful information thx for the record. Closing it to aggregate the problem into one issue. #4223

@molnard molnard closed this as completed Jan 25, 2024
@molnard molnard reopened this Jan 25, 2024
@molnard molnard closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants