Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] password input three times at wallet generation #10367

Closed
MaxHillebrand opened this issue Mar 27, 2023 · 3 comments · Fixed by #11390
Closed

[VDG] password input three times at wallet generation #10367

MaxHillebrand opened this issue Mar 27, 2023 · 3 comments · Fixed by #11390
Assignees
Labels
Milestone

Comments

@MaxHillebrand
Copy link
Collaborator

in 1.0, at wallet generation the password was requested only once, and then at first wallet load the password was checked.

in 2.0, at wallet genreration the password is requested twice, and the legacy 1.0 first load password checks again, so there are three password inputs currently. This should be reduced to two.

Either keep the two password inputs at wallet generation, and remove the first load password check.

Or remove one password input at wallet generation, and keep the first load password check.

@yahiheb
Copy link
Collaborator

yahiheb commented Mar 27, 2023

We should not remove the two password inputs at generation, that is necessary to check the password.

What could be done here to improve the UX is to automatically load/open the newly generated wallet once it is created, because most of the time users create a wallet to then load and use it.

Make sure that this works for all types of wallet creation.

@editwentyone
Copy link

please see this video from ~2:30 #10661 (comment)

@TChukwuleta
Copy link
Contributor

Hello. Good day team.

So I worked on this issue following the instructions in the video.
Would appreciate feedback: #11073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment