Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX/UI redesign] Coloring and Grouping Numbers #10838

Open
editwentyone opened this issue Jun 2, 2023 · 13 comments
Open

[UX/UI redesign] Coloring and Grouping Numbers #10838

editwentyone opened this issue Jun 2, 2023 · 13 comments
Labels
Milestone

Comments

@editwentyone
Copy link

editwentyone commented Jun 2, 2023

tackling the following issues: #10518, #2588, #10609

key takeaways

  • focus on one font, as soon as possible with avalonia (target font: Inter)
  • colouring leading Zeros 0 different than the actual value
  • use slashed Zeros 0 to distinguish between capital O
  • use mono spaced version to format numbers, dates, time and hashes inside the whole app

🎨 Figma

wasabi_digits.mp4
@yahiheb
Copy link
Collaborator

yahiheb commented Jun 2, 2023

  • use slashed Zeros 0 to distinguish between capital O

I am not sure about this one.
Through out the whole video all the places where the slashed Zeros were used it was clear that it is a 0 not a capital O.

  • When you are reading this number 113095 or 127.0.0.1:1833 or any price or any date there is no way that someone thinks it is a capital O.
  • Seeing the address with slashed Zeros look confusing.

The original issue and confusion comes from the inconsistency and to solve that we can simply use normal 0 everywhere.

@editwentyone
Copy link
Author

slashed zeros are slashing any confusion about 0, o and O. its either way: everywhere or nowhere, mixing is adding to the initial confusion.

its clear for the advanced user that 127.0.0.1 can never have O. but we are creating this software for a lot of different user personas with different skill level. one way to achieve consistency is: zeros are slashed, no matter where and in what context. or the other way around: no slashed zeros at all. doesnt matter where » problems with hashes and newbie users.

@yahiheb
Copy link
Collaborator

yahiheb commented Jun 2, 2023

everywhere or nowhere, mixing is adding to the initial confusion.

That is my point, do not use it everywhere, specially in addresses.

we are creating this software for a lot of different user personas with different skill level. one way to achieve consistency is: zeros are slashed

Simple users might be confused with the slashed Zeros.

@MaxHillebrand
Copy link
Collaborator

This is excellent, cACK.

FYI, bech32 has the number 0, but not the letter O in it's character set to avoid confusions. So at least in address and amount we don't have to care about the confusing similarities.

@yahiheb
Copy link
Collaborator

yahiheb commented Jun 3, 2023

FYI, bech32 has the number 0, but not the letter O in it's character set to avoid confusions. So at least in address and amount we don't have to care about the confusing similarities.

That was my reasoning too, and thus if we don't have it in addresses and amounts then we shouldn't have it anywhere for consistency and simplicity.

@nostitos
Copy link

nostitos commented Jun 4, 2023

Same thing, I don't like the crossed zeros, there is no possible confusion anyways.

The rest looks good, I like the grayed leading 0s

@editwentyone
Copy link
Author

Again, there are users who like slashed zeros and there are others who don’t.

I don’t really care, just for that issue, we could flip a coin.

the rest like coloring, spacing and consistency are another story.

So who wants to decide the slashes zeros? ;)

@MaxHillebrand
Copy link
Collaborator

I just flipped a coin, and it landed on empty zero, so do NOT use a slashed zero, unless you are comfortable with defying the gods of chance.

@editwentyone
Copy link
Author

@soosr
Copy link
Collaborator

soosr commented Jun 6, 2023

FTR it is not possible until Avalonia implements support for font features, We might get it in 11.X.

@turbolay
Copy link
Collaborator

This new tool from mempool.space: https://mempool.space/tools/calculator
implemented the exact colouring scheme proposed here. See how clear it is!

@stale
Copy link

stale bot commented Sep 16, 2023

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 16, 2023
@nostitos
Copy link

nostitos commented Sep 17, 2023 via email

@stale stale bot removed the stale label Sep 17, 2023
@MaxHillebrand MaxHillebrand added this to the v2.0.7 milestone Dec 27, 2023
@MaxHillebrand MaxHillebrand modified the milestones: v2.0.7, v2.0.8 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants