[VDG] Change avoidance: Display suggested amount in btc not usd

[yahiheb]

As mentioned in #10966 (review), for change avoidace the suggested amount to add or subtract should be displayed in btc not usd:

• Most bitcoiners use btc as denomination not usd or whatever shitcoin.
• To avoid cases where the usd amount is 0.00:

[turbolay]

Maybe add USD amount when hovering if we really want to have it?

[soosr]

nACK for displaying it in BTC.
The goal there is to emphasize that the suggested transaction will send less/more with X amount. Displaying it in BTC would make it hard for everyone to know exactly how much the difference is. And they would have to enter the amount every time into a converter.

They can also hover over the suggestions and see the exact amount on the preview screen.

To avoid cases where the usd amount is 0.00

This needs to be handled rather.

[yahiheb]

nACK for displaying it in BTC.
The goal there is to emphasize that the suggested transaction will send less/more with X amount. Displaying it in BTC would make it hard for everyone to know exactly how much the difference is. And they would have to enter the amount every time into a converter.

You are thinking with fiat/usd mindset, most bitcoiners use btc as denomination not usd.
If that is the case why is the btc amount the main one to enter when sending bitocoin? Why don't we make the usd amount the main one?

And why should it be in usd? Many people don't care or know about the usd exchange rate, some they know about the Euro or Yen or Yuan ... exchange rate.

[turbolay]

I thought a bit about that, and even if I'd prefer to have it always in BTC, maybe we could:
If the user writes the amount using the BTC side of the DualCurrencyBox, display in BTC.
If he used the USD side, display in USD.

[soosr]

Discussed on @zkSNACKs/ux-team meeting, the solution is the following:

• Suggestions' text will be modified
  • The text about the outcome will be removed
  • BTC amount will be added
• To show the outcome of each suggestion, when they hover over it, the warnings that would go away by picking that suggestion, will be faded out.

With this, we can indicate better how effective a suggestion is (i.e.: Full privacy also removes change), and the BTC amount has enough space. Moreover on hover not just the preview screen will display the suggested transaction, but also the warnings will be modified based on it.

(Note, the design on Figma is not updated, the screen is just for showing the UX)