Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent spelling of CoinJoin #12282

Closed
2 tasks
fulldecent opened this issue Jan 18, 2024 · 4 comments
Closed
2 tasks

Use consistent spelling of CoinJoin #12282

fulldecent opened this issue Jan 18, 2024 · 4 comments

Comments

@fulldecent
Copy link
Contributor

General Description

CoinJoin is referenced as each "Coinjoin" "coinjoin" and "CoinJoin" in the Wasabi wallet software.

How To Reproduce?

  1. See screenshots

Screenshots

Screenshot 2024-01-18 at 13 45 38

297597652-e6e9eb84-ea09-4b92-ac3b-5f904467232d

And for reference, but possibly out of scope for this issue

Screenshot 2024-01-18 at 13 48 51

Operating System

Mac

Logs

n/a

Wasabi Version

2.0.5

Recommended Fix

  • Identify the authoritative source on the naming of CoinJoin/coinjoin/Coinjoin
  • Use that name everywhere
@MaxHillebrand
Copy link
Collaborator

The "correct" spelling we've adopted is all lower case "coinjoin", unless it's at the beginning of the sentence, then it's "Coinjoin".

Other than the terms and conditions, all your Screenshots are therefor correct.

The T&C are difficult to change, so that's a won't fix.

I'm closing this, if there's a wrong spelling elsewhere please reopen it.

@MaxHillebrand MaxHillebrand closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
@fulldecent
Copy link
Contributor Author

Thank you got it. And for documentation purposes here in this issue, may you please reference where is the authoritative source of speaking for coinjoin?

I'm not sure if the Wasabi project owns coinjoin or if some other entity and what is its main homepage.

@MaxHillebrand
Copy link
Collaborator

MaxHillebrand commented Jan 18, 2024

There is https://coinjoins.org, but there's no authoritative source, coinjoin is just an idea.

fulldecent added a commit to fulldecent/WalletWasabi that referenced this issue Jan 18, 2024
fulldecent added a commit to fulldecent/WalletWasabi that referenced this issue Jan 18, 2024
@fulldecent
Copy link
Contributor Author

Awesome, thank you. Added two PRs for stray usage of old spelling.

#12283

#12284

yahiheb added a commit that referenced this issue Jan 18, 2024
Update WasabiSetupRegtest.md, for #12282
yahiheb added a commit that referenced this issue Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants