Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOs] Red cross doesn't quit application after using Hide #12815

Closed
turbolay opened this issue Apr 10, 2024 · 2 comments · Fixed by #12819
Closed

[MacOs] Red cross doesn't quit application after using Hide #12815

turbolay opened this issue Apr 10, 2024 · 2 comments · Fixed by #12819
Assignees
Milestone

Comments

@turbolay
Copy link
Collaborator

turbolay commented Apr 10, 2024

Note: This was already existing prior to #12805

When I use Hide, then I'm not able to quit the application anymore the standard way. It happens whether I click on Show or I click on the icon.

In my video I show that the feature by itself to close the app with red cross is working, but the problem is only after clicking on Hide

CleanShot.2024-04-10.at.07.47.00.mp4

In some cases I also had a big freeze with loading wheel on clicking on Quit while testing this but I've not been able to repro (that why I'm trying to do it on the video)

@MaxHillebrand MaxHillebrand added this to the v2.0.7 milestone Apr 10, 2024
@wieslawsoltes
Copy link
Collaborator

Its an issue with IMainWindowService.Hide() called twice:

  • ApplicationViewModel.ShowHideCommand
  • ApplicationStateManager.ActivatableLifetimeOnDeactivated - the second call set _hideRequest = true; which is causing the issue

@wieslawsoltes
Copy link
Collaborator

@turbolay Can you try #12819 if it fixes the issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants