Build CCJ Tumbler

[nopara73]

• NOTIFICATION new-phase
• GET /api/v1/tumbler/status
• POST /api/v1/tumbler/inputs
• GET /api/v1/tumbler/input-registration-status
• POST /api/v1/tumbler/connection-confirmation
• POST /api/v1/tumbler/output
• GET /api/v1/tumbler/coinjoin
• POST /api/v1/tumbler/signature

[wintercooled]

Can you check the logic around this line in TumblerController.InputsAsync:

if (txOutResponse.Result.Value("confirmations") <= 0)
...etc

It looks like the exception is only thrown if both conditions are met whereas it seems that it should throw if either one or both are met.

[wintercooled]

In TumberController.Status:

I think using:

Version = "1"

instead of

Version = "v1"

would be better as we can do > checks within the client easier.

[wintercooled]

In TumblerController.CoinJoin we currently throw an exception if Alice has already asked for the CoinJoin transaction.

Would it not be ok to let an Alice request this > once?

What if their client quits during the process for some reason? We could make it possible to restart the client, reload the guid (assuming we have saved it locally) and rejoin the CoinJoin at the signing phase.

... just an idea.

[nopara73]

@wintercooled The logic is good, my comment was not clear. I modified the comment.
The point is, if the input registered is unconfirmed, then it's only acceptable if it's part of a previous successful CoinJoin.

// Check if inputs are unconfirmed, if so check if they are part of previous CoinJoin
if (txOutResponse.Result.Value<int>("confirmations") <= 0)
{
	if (!Global.CoinJoinStore.Transactions
		.Any(x => x.State == CoinJoinTransactionState.Succeeded && x.Transaction.GetHash() == op.Hash))
	{
		throw new ArgumentException("Provided input is not confirmed, nor spends a previous CJ transaction");
	}
}

[nopara73]

Version = "1"

Ok, I was thinking of this myself, too. Fixed.

[nopara73]

Would it not be ok to let an Alice request this > once?

The reason is, because I don't want to get DoSd. If it becomes a problem we can do that, I'd keep it this way for now.

We could make it possible to restart the client, reload the guid (assuming we have saved it locally) and rejoin the CoinJoin at the signing phase.

If it'd be needed that'd mean we failed. Signing phase should happen close to instantly.